From 844350ab097e074b70c45cb1b6dcd19c4bf9af65 Mon Sep 17 00:00:00 2001
From: Warren Hood <nullbyte001@gmail.com>
Date: Sat, 17 Aug 2024 22:17:59 +0200
Subject: [PATCH] Improve logging when we can't find a package

---
 src/main.rs               | 2 +-
 src/providers/modrinth.rs | 9 ++++++---
 src/resolver.rs           | 5 +++++
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/main.rs b/src/main.rs
index 076d18d..6647365 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -6,7 +6,7 @@ mod resolver;
 use clap::{Parser, Subcommand};
 use mod_meta::{ModMeta, ModProvider};
 use modpack::ModpackMeta;
-use std::{borrow::BorrowMut, error::Error, path::PathBuf};
+use std::{error::Error, path::PathBuf};
 
 /// A Minecraft Modpack Manager
 #[derive(Parser)]
diff --git a/src/providers/modrinth.rs b/src/providers/modrinth.rs
index 3d71b81..4d0c7f8 100644
--- a/src/providers/modrinth.rs
+++ b/src/providers/modrinth.rs
@@ -64,9 +64,12 @@ impl Modrinth {
         versions.reverse();
 
         let package = if mod_meta.version == "*" {
-            versions
-                .last()
-                .ok_or(format!("Cannot find package {}", mod_meta.name))?
+            versions.last().ok_or(format!(
+                "Cannot find package {} for loader={} and mc version={}",
+                mod_meta.name,
+                pack_meta.modloader.to_string().to_lowercase(),
+                pack_meta.mc_version
+            ))?
         } else {
             let expected_version = semver::Version::parse(&mod_meta.version)?;
             versions
diff --git a/src/resolver.rs b/src/resolver.rs
index ea63005..643344c 100644
--- a/src/resolver.rs
+++ b/src/resolver.rs
@@ -99,6 +99,11 @@ impl PinnedPackMeta {
                                 .collect());
                         }
                         return Ok(vec![]);
+                    } else if let Err(e) = pinned_mod {
+                        eprintln!(
+                            "Failed to resolve {}@{} with provider {:#?}: {}",
+                            mod_metadata.name, mod_metadata.version, mod_provider, e
+                        );
                     }
                 }
                 crate::mod_meta::ModProvider::Raw => unimplemented!(),